Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document when zio-kafka is faster than raw java kafka #1403

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

erikvanoosten
Copy link
Collaborator

No description provided.

docs/index.md Outdated Show resolved Hide resolved
@svroonland
Copy link
Collaborator

In ZioKafkaConsumerBenchmark.throughput:

Consumer
             .plainStream(Subscription.topics(topic1), Serde.byteArray, Serde.byteArray)
             .tap { _ =>
               counter.updateAndGet(_ + 1).flatMap(count => Consumer.stopConsumption.when(count == recordCount))
             }

Do you think it would be more fair to replace the tap with a tapChunk? In the manual kafka equivalent benchmark, we also process records by the batch instead of per record.

@erikvanoosten
Copy link
Collaborator Author

Do you think it would be more fair to replace the tap with a tapChunk?

Yes, I agree. Will you make a PR?

@svroonland
Copy link
Collaborator

See #1409

@erikvanoosten erikvanoosten merged commit e689977 into master Dec 3, 2024
12 of 13 checks passed
@erikvanoosten erikvanoosten deleted the faster-then-kafka branch December 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants